This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Add support for sending magic links to inexistent accounts #822
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
hafizrahman
approved these changes
Nov 18, 2024
hafizrahman
left a comment
hafizrahman
left a comment
There was a problem hiding this comment.
First time reviewing Obj C so bear with me if anything's missing. But from what I can tell the logic is pretty sound here.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Part of woocommerce/woocommerce-ios#14419
This PR updates the magic link request with an option to pass the option
create_account, this option allows to use the same request for signup flow needed for the above task.Testing Details
Use woocommerce/woocommerce-ios#14431
CHANGELOG.mdif necessary.